Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #149

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Dependency updates #149

merged 1 commit into from
Feb 10, 2025

Conversation

mbien
Copy link
Member

@mbien mbien commented Feb 1, 2025

  • only point releases
  • all tests pass on JDK 24
  • unit tests would pass on JDK 24 if bytebuddy would be bumped (not done since transitive mockito dependency, this should resolve itself automatically)
  • added JDK 23 to test matrix

haven't deployed this version yet. leaving it as draft till then

@snoopdave
Copy link
Contributor

snoopdave commented Feb 1, 2025

Thanks @mbien! This looks good. I don't know what you mean about the Mokito thing: "this should resolve itself automatically"?

@mbien
Copy link
Member Author

mbien commented Feb 2, 2025

I don't know what you mean about the Mokito thing: "this should resolve itself automatically"?

Hi @snoopdave! At some point mockito will release a new version which will bump its dependencies to JDK 24 compatible versions. At that point it will "just work" after roller updates the mockito version without having to declare a direct (test) dependency on bytebuddy. That is what I meant by this will fix itself after a while.

(I manually tested bumping bytebuddy to the latest version and tests passed on JDK 24)

@mbien
Copy link
Member Author

mbien commented Feb 2, 2025

mvn eu.maveniverse.maven.plugins:toolbox:gav-tree -Dgav=org.mockito:mockito-core:5.14.1
[INFO] --- toolbox:0.6.1:gav-tree (default-cli) @ standalone-pom ---
[INFO] org.mockito:mockito-core:jar:5.14.1
[INFO] ├─net.bytebuddy:byte-buddy:jar:1.15.3 [compile]
[INFO] ├─net.bytebuddy:byte-buddy-agent:jar:1.15.3 [compile]
[INFO] ╰─org.objenesis:objenesis:jar:3.3 [runtime]

btw https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.16.0

Include support for JDK Class File API.

bytebuddy 1.16 and later should no longer cause this kind of problem thanks for using plain JDK APIs. So mockito won't have to update the dependency that often.

@mbien
Copy link
Member Author

mbien commented Feb 2, 2025

@snoopdave oops i didn't realize that there is already a newer mockito available - will update this PR

 - only point releases
 - tests pass on JDK 24
 - added JDK 23 to test matrix
@mbien mbien force-pushed the dependency-updates-6 branch from b39d953 to 2c5f7b2 Compare February 2, 2025 10:45
@mbien
Copy link
Member Author

mbien commented Feb 2, 2025

updated, everything passes on JDK 24 now

Copy link
Contributor

@snoopdave snoopdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and checks are passing 🐝

@snoopdave
Copy link
Contributor

@mbien are we good to merge this? I'd like to get it into 6.1.5 rc1

@mbien mbien marked this pull request as ready for review February 10, 2025 01:32
@mbien
Copy link
Member Author

mbien commented Feb 10, 2025

@snoopdave Should be fine - although I haven't deployed it this time around for manually testing. JQuery update is always a bit risky since it probably doesn't have any test coverage. Rest should be good.

@mbien mbien merged commit edd9b52 into apache:master Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants