-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #149
Dependency updates #149
Conversation
Thanks @mbien! This looks good. I don't know what you mean about the Mokito thing: "this should resolve itself automatically"? |
Hi @snoopdave! At some point mockito will release a new version which will bump its dependencies to JDK 24 compatible versions. At that point it will "just work" after roller updates the mockito version without having to declare a direct (test) dependency on bytebuddy. That is what I meant by this will fix itself after a while. (I manually tested bumping bytebuddy to the latest version and tests passed on JDK 24) |
btw https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.16.0
bytebuddy 1.16 and later should no longer cause this kind of problem thanks for using plain JDK APIs. So mockito won't have to update the dependency that often. |
@snoopdave oops i didn't realize that there is already a newer mockito available - will update this PR |
- only point releases - tests pass on JDK 24 - added JDK 23 to test matrix
b39d953
to
2c5f7b2
Compare
updated, everything passes on JDK 24 now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and checks are passing 🐝
@mbien are we good to merge this? I'd like to get it into 6.1.5 rc1 |
@snoopdave Should be fine - although I haven't deployed it this time around for manually testing. JQuery update is always a bit risky since it probably doesn't have any test coverage. Rest should be good. |
unit tests would pass on JDK 24 if bytebuddy would be bumped (not done since transitive mockito dependency, this should resolve itself automatically)haven't deployed this version yet. leaving it as draft till then