in tests replace deprecated IndexSearcher.doc() calls #3149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmiley
approved these changes
Feb 1, 2025
There was a problem hiding this comment.
In a number (all?) places here, you have a SolrIndexSearcher so could call getDocFetcher().doc(id) which is the Solr way to do this, not calling storedFields(). I leave it to you to contemplate which path makes the most sense based on the test. But I think the solr-way is preferred unless the test is particularly low-level (like "uninverting" package.
cpoerschke
commented
Feb 3, 2025
| @@ -183,12 +183,12 @@ private void testRange(int precisionStep) throws Exception { | |||
| ScoreDoc[] sd = topDocs.scoreDocs; | |||
| assertNotNull(sd); | |||
| assertEquals("Score doc count" + type, count, sd.length); | |||
| Document doc = searcher.doc(sd[0].doc); | |||
| Document doc = searcher.storedFields().document(sd[0].doc); | |||
There was a problem hiding this comment.
Here we have an IndexSearcher i.e. not a SolrIndexSearcher and so not using SolrIndexSearcher.getDocFetcher() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is deprecated since Lucene 9.5 - https://github.com/apache/lucene/blob/releases/lucene/9.5.0/lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java#L382-L391 -- and remove in Lucene 10.
So the replacement here can go to both
mainandbranch_9xbranches with no JIRA or solr/CHANGES.txt entry needed in my opinion.