[SPARK-51110][CORE][SQL] Proper error handling for file status when reading files #49833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fusheng9399
changed the title
MaxGekk
reviewed
Feb 6, 2025
| } catch { | ||
| case e: Exception => | ||
| logError(s"Failed to filter out path names from ${path.toString}", e) | ||
| throw SparkException.internalError(s"Unexpected statuses for path ${path.toString}", e) |
There was a problem hiding this comment.
Can users face to the error? If so, we shouldn't use internalError. How do you repro the issue?
There was a problem hiding this comment.
Can users face to the error? If so, we shouldn't use
internalError. How do you repro the issue?
No, users cannot face this error because it is an internal error at the spark internal layer, hence the use of "internalError". It is difficult to repro, as multiple attempts have failed to repro the issue. What would be a suitable recommendation to address this issue?
There was a problem hiding this comment.
What would be a suitable recommendation to address this issue?
Could you try a fake filesystem, see
added 2 commits
February 7, 2025 13:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add clear error messages for reading a file
Why are the changes needed?
For these errors, we report ambiguous errors now. For example, sometimes Spark job will report NPE (Null Pointer Exception) as follows:
but users do not know which specific file caused it.
Does this PR introduce any user-facing change?
Yes, a meaningful error is given when visiting an unknown error file.
How was this patch tested?
manually test
Was this patch authored or co-authored using generative AI tooling?
No