[SPARK-50615][FOLLOWUP][SQL] Avoid dropping metadata in the push rule. #50121
+35
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There is a bug in the initial optimizer rule that the
outputof the relation will be rebuilt based on the schema of theHadoopFsRelation. This schema doesn't include file metadata (the_metadatacolumn). This PR fixes the bug. The new implementation no longer requireshadoopFsRelation.schemaandrelation.outputto have the same order, which I don't think is guaranteed.Why are the changes needed?
It is a necessary bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test. It would fail without the fix.
Was this patch authored or co-authored using generative AI tooling?
No.