Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYSTEMDS-3824] Decompressing Transpose #2217

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

Baunsgaard
Copy link
Contributor

Sebastian Baunsgaard [email protected] introduced a new CLALib for Reorg, specifically Transpose

e-strauss [email protected] applied minor changes:

  • a manual rewrite in bultin kmeans script to use argmin (reduced runtime by 18%)
  • added new decompressing transpose to DenseBlock from SparseBlock for ColGroupDDC
  • fixed bug in sparsity evaluation in decompressed transposed (switch nrow w/ ncol)
  • minor bug fix in regarding the cached decompression count
  • fixed ctable with seq fuse rewrite fused ctable with given output dim (disaled: performance decrease, need to fix it first)
  • fixed null handling in fused seq ctable
  • fixed tests which passed for the wrong reason

Sebastian Baunsgaard <[email protected]> introduced a new CLALib for Reorg, specifically Transpose

e-strauss <[email protected]> applied minor changes:
- a manual rewrite in bultin kmeans script to use argmin (reduced runtime by 18%)
- added new decompressing transpose to DenseBlock from SparseBlock for ColGroupDDC
- fixed bug in sparsity evaluation in decompressed transposed (switch nrow w/ ncol)
- minor bug fix in regarding the cached decompression count
- fixed ctable with seq fuse rewrite fused ctable with given output dim (disaled: performance decrease, need to fix it first)
- fixed null handling in fused seq ctable
- fixed tests which passed for the wrong reason

Co-authored-by: e-strauss <[email protected]>
Co-authored-by: Sebastian Baunsgaard <[email protected]>
@Baunsgaard Baunsgaard merged commit dc3947a into apache:main Feb 5, 2025
43 of 44 checks passed
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 43.38235% with 77 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (fd1ba7c) to head (dc3947a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...apache/sysds/runtime/compress/lib/CLALibReorg.java 14.75% 48 Missing and 4 partials ⚠️
...e/sysds/runtime/compress/colgroup/ColGroupDDC.java 0.00% 13 Missing ⚠️
...ache/sysds/runtime/compress/lib/CLALibRexpand.java 90.00% 1 Missing and 2 partials ⚠️
...time/instructions/cp/CompressionCPInstruction.java 0.00% 3 Missing ⚠️
...s/runtime/instructions/cp/CtableCPInstruction.java 62.50% 1 Missing and 2 partials ⚠️
...ache/sysds/runtime/matrix/data/LibMatrixReorg.java 89.47% 0 Missing and 2 partials ⚠️
.../sysds/runtime/compress/CompressedMatrixBlock.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2217      +/-   ##
============================================
- Coverage     72.40%   72.39%   -0.02%     
- Complexity    45368    45384      +16     
============================================
  Files          1467     1468       +1     
  Lines        170710   170790      +80     
  Branches      33286    33303      +17     
============================================
+ Hits         123603   123638      +35     
- Misses        37705    37754      +49     
+ Partials       9402     9398       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant