Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Refactor Matrix append #2219

Closed

Conversation

Baunsgaard
Copy link
Contributor

This PR contains a refactor of MatrixBlock.append, the refactor serves two purposes.

  1. The append logic inside the MatrixBlock, was > 200 lines with many specific functions only for append logic.
  2. To allow JIT compilation of the Sparse and Dense appending respectively. The current implementation contained one big method that did not -- in my experiments -- JIT compile ever.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 94.62366% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (5ff6274) to head (8e4598a).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...che/sysds/runtime/matrix/data/LibMatrixAppend.java 94.56% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2219      +/-   ##
============================================
- Coverage     72.38%   72.37%   -0.02%     
+ Complexity    45381    45378       -3     
============================================
  Files          1468     1469       +1     
  Lines        170802   170810       +8     
  Branches      33306    33305       -1     
============================================
- Hits         123634   123622      -12     
- Misses        37762    37782      +20     
  Partials       9406     9406              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Baunsgaard Baunsgaard closed this in b43fa11 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant