Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to JakartaEE 8 #2777

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Migration to JakartaEE 8 #2777

merged 2 commits into from
Apr 27, 2023

Conversation

bogdandrutu
Copy link
Contributor

@bogdandrutu bogdandrutu commented Apr 7, 2023

Migrate to JakartaEE 8 dependencies which use the same namespace as the JavaEE 8.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Signed-off-by: Bogdan Drutu <[email protected]>
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough about Gradle, but it seems like it'd be a good idea to try to use the BOM that JakartaEE provides, for managing the dependency versions.

Maybe something like:

implementation group: 'jakarta.platform', name: 'jakarta.jakartaee-bom', version: '8.0.0'

@Jens-G Jens-G added the java Pull requests that update Java code label Apr 8, 2023
@bogdandrutu
Copy link
Contributor Author

Unfortunately the 8.0.0 bom has few problems and would like to not spread it in the world. See jakartaee/jakartaee-api#136 and jakartaee/jakartaee-api#49 (not included in the bom). Because of that I would avoid it until an 8.1.0 (or 8.0.1) is released.

@jimexist jimexist merged commit 172ad9b into apache:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants