-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UNOMI-616 - Update GraphQL Playground to the latest version or switch to GraphiQL #648
Conversation
0b8cf37
to
bafdcb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anatol,
Thank you very much for the PR, I just think we should rename the project from graphql-playground to graphql-ui what do you think ?
Regards,
Serge...
bafdcb2
to
5bf7a62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Anatol,
Thank you very much for the changes. I approved the PR.
Regards,
Serge...
a166c10
to
b2ec13f
Compare
I think that before merging we should analyze what is making the tests fail. @anatol-sialitski could you look into it ? Thanks. |
b2ec13f
to
038763c
Compare
I tried running the tests locally and it seems there is an error while trying to install the GraphQL feature : Here's the log from the console : Fri May 17 14:45:59 CEST 2024: Finish execution of: {version=2.4.0, name='viewEventPagePath', bundle=org.apache.unomi.shell-commands} unomi:start and from the logs : 2024-05-17T14:47:18,897 | ERROR | pool-13-thread-1 | BundleWatcherImpl | 218 - org.apache.unomi.lifecycle-watcher - 2.5.0.SNAPSHOT | Error when installing cdp-graphql-feature feature |
This has been done in the new PR #681 |
UNOMI-616 - Update GraphQL Playground to the latest version or switch to GraphiQL
Switched from GraphQL Playground to GraphiQL Playground v3.0.6