ZOOKEEPER-4775 Rewrite check_zookeeper from py2 to py3 #2094
Conversation
|
I have created this JIRA for you |
eolivelli
changed the title
There was a problem hiding this comment.
Tested by ./check_zookeeper.py --servers 127.0.0.1:2180 with Python 3.8.9
Server: 127.0.0.1:2180
zk_outstanding_tls_handshake 0.0
zk_diff_count 0.0
..............................................................................
zk_sync_process_time{quantile="0.5"} 0.0
zk_snapshottime_count 1.0
Ennnn, I need to test check_zookeeper.py3
| @@ -0,0 +1,404 @@ | |||
| #! /usr/bin/env python3 | |||
There was a problem hiding this comment.
check_zookeeper.py3 should keep the same permission as check_zookeeper.py:
-rwxr-xr-x@ 1 maoling staff 13057 Jun 20 2022 check_zookeeper.py*
otherwise: permission denied: ./check_zookeeper.py3
| print ('Server:'), server | ||
|
|
||
| for key, value in stats.items(): | ||
| print ("%30s") % key, ' ', value |
There was a problem hiding this comment.
With python3.8, this line cannot pass the compiler. Maybe I'm wrong since I don't know python.
My chatgpt tell me it should be like print("{:<30} {}".format(key, value)) and it works well
Rewrite check_zookeeper.py to check_zookeeper.py3 which works when using python3.