Keyboard is now automatically dismissed when an item is selected. #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be better to make it as param instead of auto dismiss with no option? |
Sure, do you think it should be the default option or not? |
|
Why not? Let it hide by default. But if someone need to keep it - he can change behaviour. |
|
@mrDeadLinez I have added a parameter to turn this behaviour off. |
hydrated
reviewed
Nov 15, 2018
| @@ -595,6 +598,9 @@ extension SearchTextField: UITableViewDelegate, UITableViewDataSource { | |||
| public func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { | |||
| if itemSelectionHandler == nil { | |||
| self.text = filteredResults[(indexPath as NSIndexPath).row].title | |||
| if autoDismiss{ | |||
There was a problem hiding this comment.
A space before opening brass would be nicer.
hydrated
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple, but effective, quality of life improvement for users.