Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling error printing #393

Merged
merged 3 commits into from
Jul 22, 2021
Merged

Conversation

Magiczne
Copy link
Contributor

@Magiczne Magiczne commented Jul 13, 2021

Closes #392

@jfritschi
Copy link
Contributor

Thanks for the pull.

Shouldn't we just extend the exiting $_PHPCAS_VERBOSE to also cover the exception case? Seems like it's more or less the same topic the same and I don't see much benefit of complicating things more....

Any other opinions? @phy25 ?

@Magiczne
Copy link
Contributor Author

Magiczne commented Jul 16, 2021

@jfritschi Sure i thought about that, but it would mean that this one line of HTML will be removed:

echo "<br />\n<b>Error</b>: <font color=\"FF0000\"><b>". DEFAULT_ERROR ."</b><br />\n";

But I think since it only shows default error it could be removed and that would mean using $_PHPCAS_VERBOSE will show the HTML. If it suits i will make changes to the PR later.

That being said i think the best way to handle that is to use $_PHPCAS_VERBOSE inside the printHTMLHeader and printHTMLFooter to not display anything when verbose is not true.

@Magiczne
Copy link
Contributor Author

I've updated PR with approach based on existing verbosity flag.

@jfritschi
Copy link
Contributor

Closes #129

@jfritschi
Copy link
Contributor

Thanks for your contribution!

@Magiczne
Copy link
Contributor Author

@jfritschi No problem. When the new version release can be expected?

@jfritschi
Copy link
Contributor

No, release is planned in the near future and I wont have the time until September... We are lacking real active maintainers at the moment.

@lewart
Copy link

lewart commented Sep 20, 2021

I think this change was pretty awaited by the authors of many applications and will be used as soon as it's released.
Thanks goes to You, Magiczne!

I think that after a commit 77fa745 above, the constant DEFAULT_ERROR is no longer used. Can it be removed?

@Magiczne Magiczne deleted the feature/disable-errors branch September 21, 2021 10:54
@jfritschi
Copy link
Contributor

@lewart The constant has been removed... Thank you @Magiczne for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No ability to disable displaying errors directly into the response.
3 participants