-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling error printing #393
Conversation
Thanks for the pull. Shouldn't we just extend the exiting $_PHPCAS_VERBOSE to also cover the exception case? Seems like it's more or less the same topic the same and I don't see much benefit of complicating things more.... Any other opinions? @phy25 ? |
@jfritschi Sure i thought about that, but it would mean that this one line of HTML will be removed: echo "<br />\n<b>Error</b>: <font color=\"FF0000\"><b>". DEFAULT_ERROR ."</b><br />\n"; But I think since it only shows default error it could be removed and that would mean using That being said i think the best way to handle that is to use |
This reverts commit 7e040db.
I've updated PR with approach based on existing verbosity flag. |
Closes #129 |
Thanks for your contribution! |
@jfritschi No problem. When the new version release can be expected? |
No, release is planned in the near future and I wont have the time until September... We are lacking real active maintainers at the moment. |
I think this change was pretty awaited by the authors of many applications and will be used as soon as it's released. I think that after a commit 77fa745 above, the constant DEFAULT_ERROR is no longer used. Can it be removed? |
Closes #392