Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding DNS header #587

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding DNS header #587

wants to merge 2 commits into from

Conversation

Cl-He-O
Copy link

@Cl-He-O Cl-He-O commented Mar 17, 2023

Mostly copied from Xray-core's DNS header, useful for bypassing school network's login.

@tobyxdd tobyxdd requested review from tobyxdd and haruue March 17, 2023 23:21
@tobyxdd tobyxdd added the enhancement New feature or request label Mar 17, 2023
@tobyxdd
Copy link
Collaborator

tobyxdd commented Mar 22, 2023

I love the idea of adding a DNS mode but I have some concerns about this implementation - using obfs as the argument for the domain name & removing the actual obfuscation process means that packets will always have a plain text DNS header + QUIC header, which obviously does not seem legitimate...

Maybe we should consider adding a new field in config to provide arguments to fake protocols like this?

@Cl-He-O
Copy link
Author

Cl-He-O commented Mar 23, 2023

It would be better for sure. But I met difficulty in implementing it, the type of function won't match after adding a new parameter...

@apernet apernet deleted a comment from us254 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyxdd tobyxdd Awaiting requested review from tobyxdd

@haruue haruue Awaiting requested review from haruue

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cl-He-O @tobyxdd