feat: Replace HeaderGenerator implementation by browserforge implementation
#960
+211
−1,144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Tests, JS page function for injecting fingerprint json.
Todo: Make it work with page.add_init_script
Added dev test TODO: Add proper tests Sync header generation with fingerprint generation (use gen from browserforge)
Use browser_pool_options from crawler to pass fingerprint related stuff to be similar to JS
Draft adapter and basic test.
TODO: Solve circular imports
Remove types unused in this change. Format, lint, type check.
(Hint about browserforge being just implementation detail and not core functionality.)
Co-authored-by: Vlada Dusek <[email protected]>
(To avoid some import race conditions downloads when running pytest with multiple processes)
github-actions
bot
added
t-tooling
Pijukatel
changed the title
HeaderGenerator implementation by browserforge implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces internal
HeaderGeneratorimplementation byBrowserForgeimplementation.Issues