Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Test & Update docs #157

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/apigee-x-core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
| Name | Version |
|------|---------|
| <a name="provider_google-beta"></a> [google-beta](#provider\_google-beta) | >= 4.20.0 |
| <a name="provider_random"></a> [random](#provider\_random) | n/a |

## Modules

Expand All @@ -20,6 +21,7 @@
| Name | Type |
|------|------|
| [google-beta_google_project_service_identity.apigee_sa](https://registry.terraform.io/providers/hashicorp/google-beta/latest/docs/resources/google_project_service_identity) | resource |
| [random_string.key_random_suffix](https://registry.terraform.io/providers/hashicorp/random/latest/docs/resources/string) | resource |

## Inputs

Expand Down
14 changes: 12 additions & 2 deletions modules/apigee-x-core/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,14 @@ resource "google_project_service_identity" "apigee_sa" {
service = "apigee.googleapis.com"
}



resource "random_string" "key_random_suffix" {
length = 6
special = false
}


module "kms-org-db" {
source = "github.com/terraform-google-modules/cloud-foundation-fabric//modules/kms?ref=v28.0.0"
project_id = var.project_id
Expand All @@ -39,7 +47,8 @@ module "kms-org-db" {
}
keyring = {
location = coalesce(var.org_kms_keyring_location, var.ax_region)
name = var.org_kms_keyring_name

name = "${var.org_kms_keyring_name}-${random_string.key_random_suffix.result}"
}
keyring_create = var.org_kms_keyring_create
keys = {
Expand All @@ -56,7 +65,8 @@ module "kms-inst-disk" {
}
keyring = {
location = coalesce(each.value.keyring_location, each.value.region)
name = coalesce(each.value.keyring_name, "apigee-${each.key}")
name = "${coalesce(each.value.keyring_name, "apigee-${each.key}")}-${random_string.key_random_suffix.result}"

}
keyring_create = each.value.keyring_create
keys = {
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_controlled_internet_egress.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 39
assert len(resources) == 40


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_dns_peering.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 45
assert len(resources) == 46


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_ilb_mtls.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 49
assert len(resources) == 50


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_l4xlb_mtls.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 52
assert len(resources) == 53


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_l7xlb.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 44
assert len(resources) == 45


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_multi_region.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 60
assert len(resources) == 61


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_nb_psc_xlb.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 42
assert len(resources) == 43


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_sb_psc.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 46
assert len(resources) == 47


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_shared_vpc.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 53
assert len(resources) == 54


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_transtive_peering.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 60
assert len(resources) == 61


def test_apigee_instance(resources):
Expand Down
2 changes: 1 addition & 1 deletion tests/samples/test_x_basic.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def resources(recursive_plan_runner):

def test_resource_count(resources):
"Test total number of resources created."
assert len(resources) == 31
assert len(resources) == 32


def test_apigee_instance(resources):
Expand Down