Address PR feedback from @AnthonyMDev

apollographql · Mar 22, 2024 · e31d708 · e31d708
1 parent 2a1ab11
commit e31d708
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/Tests/ApolloTests/Cache/StoreSubscriptionTests.swift b/Tests/ApolloTests/Cache/StoreSubscriptionTests.swift
@@ -1,3 +1,4 @@
+import Nimble
 import XCTest
 @testable import Apollo
 
@@ -38,27 +39,14 @@ class StoreSubscriptionTests: XCTestCase {
     wait(for: [cacheKeyChangeExpectation], timeout: Self.defaultWaitTimeout)
   }
 
-  func testUnsubscribedSubscriberDoesNotReceiveStoreUpdate() throws {
-    let cacheKeyChangeExpectation = XCTestExpectation(description: "Subscriber is notified of cache key change")
-    cacheKeyChangeExpectation.isInverted = true
-
-    let expectedChangeKeySet: Set<String> = ["QUERY_ROOT.__typename", "QUERY_ROOT.name"]
-    let subscriber = SimpleSubscriber(cacheKeyChangeExpectation, expectedChangeKeySet)
+  func testUnsubscribeRemovesSubscriberFromApolloStore() throws {
+    let subscriber = SimpleSubscriber(XCTestExpectation(), [])
 
     store.subscribe(subscriber)
 
     store.unsubscribe(subscriber)
 
-    store.publish(
-      records: [
-        "QUERY_ROOT": [
-          "__typename": "Hero",
-          "name": "Han Solo"
-        ]
-      ]
-    )
-
-    wait(for: [cacheKeyChangeExpectation], timeout: Self.defaultWaitTimeout)
+    expect(self.store.subscribers).toEventually(beEmpty())
   }
 
   /// Fufills the provided expectation when all expected keys have been observed.

diff --git a/apollo-ios/Sources/Apollo/ApolloStore.swift b/apollo-ios/Sources/Apollo/ApolloStore.swift
@@ -25,7 +25,7 @@ public class ApolloStore {
   private let cache: NormalizedCache
   private let queue: DispatchQueue
 
-  private var subscribers: [ApolloStoreSubscriber] = []
+  internal var subscribers: [ApolloStoreSubscriber] = []
 
   /// Designated initializer
   /// - Parameters: