Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update user survey conditions #258

Merged
merged 2 commits into from
Feb 6, 2024
Merged

chore: Update user survey conditions #258

merged 2 commits into from
Feb 6, 2024

Conversation

calvincestari
Copy link
Member

@calvincestari calvincestari commented Feb 5, 2024 •
edited
Loading

This skips the user survey comment when an issue is closed if the issue was opened by a maintainer and there were zero comments on the issue at the time. The parameters available through the issue event are detailed here.

Done to avoid issue survey requests like this.

@calvincestari calvincestari requested a review from a team as a code owner February 5, 2024 22:53
@netlify Netlify
Copy link

netlify bot commented Feb 5, 2024 •
edited
Loading

✅ Deploy Preview for eclectic-pie-88a2ba canceled.

Name Link
🔨 Latest commit 20f6343
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-pie-88a2ba/deploys/65c17abf38763c00074ed9fc

@calvincestari calvincestari merged commit 3188860 into main Feb 6, 2024
20 checks passed
@calvincestari calvincestari deleted the update-user-survey-conditions branch February 6, 2024 17:54
BobaFetters pushed a commit that referenced this pull request Feb 6, 2024
@calvincestari
chore: Update user survey conditions (#258)
96e01e0
BobaFetters pushed a commit to apollographql/apollo-ios that referenced this pull request Feb 6, 2024
@calvincestari
chore: Update user survey conditions (apollographql/apollo-ios-dev#258)
9855a2c
BobaFetters pushed a commit that referenced this pull request Feb 6, 2024
Squashed 'apollo-ios/' changes from 74a16c7..9855a2c
5631b74 
9855a2c chore: Update user survey conditions (#258)

git-subtree-dir: apollo-ios
git-subtree-split: 9855a2c
BobaFetters pushed a commit that referenced this pull request Feb 6, 2024
split: apollo-ios - PR #258 - chore: Update user survey conditions
5dbfbf9 
git-subtree-dir: apollo-ios
git-subtree-mainline: 96e01e0
git-subtree-split: 9855a2c
@calvincestari
Copy link
Member Author

Turns out that the author_association property of an issue is affected by your organization members visibility setting.

  • If you set it to private then you are simply seen as a contributor to the repo which breaks this change.
  • If you set it to public then you are seen as a member which is what we want for the updated condition to work.

This was the tip-off to understanding the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@calvincestari