Inherit stderr of to subprocesses for debugging #1901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
Command::output()
causes both stdout and stderr to be redirected to separate pipe. If following code does not print stderr this can cause error to be swallowed, making debugging harder.This changes to inherit stderr instead, so error messages go to Rover’s own stderr.
Example before:
We see that stdout of the subprocess is empty, but we don’t see why.
After, with
RUST_BACKTRACE=1
added: