Minor changes to Checkpointer #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzhi713
requested review from
ruomingp,
markblee and
a team
as code owners
hanzhi713
force-pushed
the
checkpoint-minor
branch
from
11a31d3 to
f262e0c
Compare
markblee
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor changes to Checkpointer
_all_checkpoint_pathsnow return full checkpoint paths to ensure similar semantic tocheckpoint_paths._restore_tensorstore_statenow takes an optional sync argument to allow skipping a sync after restore.BoundedDataShardedAsyncCheckpointManagerto be called in async functions.