Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cathaypacific.com policy #830

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

TheTimewaster
Copy link
Contributor

Overall Checklist

for password-rules.json

  • The given rule isn't particularly standard and obvious for password managers
  • Generated passwords have been tested from this rule using the Password Rules Validation Tool
  • Information has been included about the website's requirements (eg. screenshots, error messages, steps during experimentation, etc.)
  • The PR isn't documenting something that would be a common practice among password managers (e.g. minimal length of 6)

grafik

@TheTimewaster TheTimewaster changed the title Cathaypacific com policy cathaypacific.com policy Oct 9, 2024
@rmondello
Copy link
Contributor

I think the best rule for this website is:

"password-rules": "minlength: 8; maxlength: 20; required: upper; required: digit; required: [!#$*^]; allowed: lower;"

@TheTimewaster What do you think?

@TheTimewaster
Copy link
Contributor Author

@rmondello You are totally right. It double checked it and looks correct now.

image

@rmondello
Copy link
Contributor

rmondello commented Oct 10, 2024

Your rule says "require one of upper or digit", but I think you want, "require one upper. require one digit".

minlength: 8; maxlength: 20; required: upper; required: digit; required: [!#$*^]; allowed: lower;

@TheTimewaster
Copy link
Contributor Author

Alright. Thanks for pointing out. I changed it accordingly.

@rmondello rmondello merged commit d33272f into apple:main Oct 10, 2024
5 checks passed
@rmondello
Copy link
Contributor

Thank you so much, @TheTimewaster!

rmondello pushed a commit to rmondello/password-manager-resources that referenced this pull request Nov 6, 2024
* added cathaypacific.com password policy

* add star to required characters

* fix typo

* add change as allowed and upper as required

* separate upper and digit as required

* changed order from required to lower
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants