ci: Skip smoke tests for Swift 6.1 #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euanh
added
semver/none
euanh
added a commit
that referenced
this pull request
Jan 27, 2025
The `main.yml` test also needs the changes from #53, but running the pull request tests does not show this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The shared unit test workflow has been updated to run on Swift 6.1 nightlies: apple/swift-nio#3076
A new
linux_nightly_6_1_arguments_overrideparameter must be set to skip the smoke tests when running unit tests in CI.Modifications
Define
linux_nightly_6_1_arguments_overrideto ignore smoke tests.Remove
linux_nightly_6_0_arguments_overridewhich is no longer used.Result
Tests, including the daily test runs, will pass again.
Test Plan
This fixes a test failure caused by the upstream shared workflows being changed. All tests now pass again.