Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gyro CAN ID and remove TalonSRX #15

Merged
merged 1 commit into from
Jan 27, 2024
Merged

Conversation

gordonbchen
Copy link
Contributor

Description

Update gyro CAN ID and connection method (directly wired into CAN bus, no intermediate Talon SRX).

Type of change

  • New feature (non-breaking change which adds functionality)
  • Update
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bugfix (non-breaking change which fixes an issue, add DEF # above in description)
  • Environment change (changes to developer environment or CI configuration)
  • Documentation Update (if none of the other choices apply)

How Has This Been Tested?

Tested by watching gyro on shuffleboard.

Author Checklist:

  • I have performed a self-review of my code
  • I have added 1-2 reviewers
  • I have @mentioned relevant non-reviewers as an FYI
  • I have included a detailed description of my changes and their motivations

@gordonbchen gordonbchen requested review from amoscao and CJc318 January 27, 2024 19:54
Copy link
Contributor

@ApplePiRobot ApplePiRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job gordon

@ApplePiRobot ApplePiRobot merged commit b889a19 into main Jan 27, 2024
1 check passed
@ApplePiRobot ApplePiRobot deleted the gordon/update/gyro_id branch January 27, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants