Unified Viewport #2648

fu5ha · 2019-06-20T06:03:17Z

Initial unified viewport PR. Also see #2651

dictoon

Excellent work! There are some regressions in the cameras that will need to be addressed before we can merge this.

sandbox/settings/appleseed.studio.xml

src/appleseed.studio/CMakeLists.txt

src/appleseed.studio/mainwindow/mainwindow.cpp

src/appleseed.studio/mainwindow/rendering/glscenelayer.cpp

src/appleseed.studio/mainwindow/rendering/lightpathsviewportmanager.cpp

dictoon · 2019-09-22T09:51:59Z

src/appleseed/renderer/modeling/camera/orthographiccamera.cpp

@@ -80,6 +80,15 @@ namespace
            const ParamArray&       params)
          : Camera(name, params)
        {
+            // Extract the film dimensions from the camera parameters.
+            m_film_dimensions = extract_film_dimensions();


Changes in this file introduced functional regressions: it's no longer possible to change camera parameters during interactive rendering. They should be reverted.

Ah, I believe it just needs to be in both places. This is also why the variable that @oktomus noticed was there: originally I was going to factor this code out into a dedicated function but didn't realize that the params could change between the creation and when on_render_begin is called. I'll just do that now.

Maybe in this specific case you might be able to execute this code in the constructor, but this isn't true in general as at this point, inputs aren't bound to the entity. Why exactly do you need to do this?

src/appleseed/renderer/modeling/camera/orthographiccamera.cpp

dictoon · 2019-09-22T09:52:29Z

src/appleseed/renderer/modeling/camera/perspectivecamera.cpp

@@ -54,6 +54,18 @@ namespace renderer
 PerspectiveCamera::PerspectiveCamera(const char* name, const ParamArray& params)
  : Camera(name, params)
 {
+    // Extract the film dimensions from the camera parameters.
+    m_film_dimensions = extract_film_dimensions();


Same problem here.

oktomus

Thanks a lot for this amazing work !

I reviewed half of your code and i will continue once you have addressed this first part :)

Most of the comments apply to the files I haven't read yet.

oktomus · 2019-09-21T10:37:26Z

src/appleseed.studio/CMakeLists.txt

@@ -248,12 +248,14 @@ source_group ("mainwindow\\pythonconsole" FILES
 set (mainwindow_rendering_sources
    mainwindow/rendering/cameracontroller.cpp
    mainwindow/rendering/cameracontroller.h
+    mainwindow/rendering/glscenelayer.h
+    mainwindow/rendering/glscenelayer.cpp


cpp file first :)

oktomus · 2019-09-21T10:37:41Z

src/appleseed.studio/CMakeLists.txt

+    mainwindow/rendering/viewporttab.cpp
+    mainwindow/rendering/viewporttab.h
+    mainwindow/rendering/viewportwidget.h
+    mainwindow/rendering/viewportwidget.cpp


cpp first also here

src/appleseed.studio/mainwindow/mainwindow.cpp

oktomus · 2019-09-21T10:42:03Z

sandbox/settings/appleseed.studio.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <settings>
    <parameter name="autosave" value="false" />
-    <parameter name="message_verbosity" value="info" />
+    <parameter name="message_verbosity" value="debug" />


Revert this

src/appleseed.studio/mainwindow/mainwindow.cpp

src/appleseed.studio/mainwindow/rendering/lightpathslayer.cpp

oktomus · 2019-09-21T14:22:49Z

src/appleseed.studio/mainwindow/rendering/lightpathslayer.cpp

+  , m_selected_light_path_index(-1)
+  , m_gl_initialized(false)
+{
+


Remove blank line

src/appleseed.studio/mainwindow/rendering/lightpathslayer.cpp

oktomus · 2019-10-21T16:28:43Z

Closed in favor of #2661

oktomus added the WIP ⚠ label Jun 21, 2019

fu5ha mentioned this pull request Jun 24, 2019

Unified Viewport UX issues #2651

Open

3 tasks

fu5ha force-pushed the unified-viewport branch 2 times, most recently from 64481de to 75de908 Compare June 24, 2019 22:16

fu5ha changed the title ~~[WIP] Unified viewport~~ Unified viewport part 3: Light paths overlay Jun 24, 2019

fu5ha force-pushed the unified-viewport branch 4 times, most recently from a7e6a16 to bf27aaf Compare July 2, 2019 03:17

fu5ha changed the title ~~Unified viewport part 3: Light paths overlay~~ Unified Viewport Jul 9, 2019

oktomus removed the WIP ⚠ label Sep 21, 2019

dictoon force-pushed the unified-viewport branch 2 times, most recently from 795bf2e to 3e77168 Compare September 22, 2019 09:45

dictoon requested changes Sep 22, 2019

View reviewed changes

oktomus requested changes Sep 22, 2019

View reviewed changes

fu5ha and others added 4 commits October 8, 2019 09:27

Display final render in OpenGL viewport widget

c2f89f6

Option to display OpenGL scene view in viewport

e3628e7

Display optional light paths overlay over final render or opengl view

92458ac

Remove 'using namespace std' statements

448de5b

dictoon force-pushed the unified-viewport branch from 3e77168 to 448de5b Compare October 8, 2019 07:46

oktomus closed this Oct 19, 2019

oktomus reopened this Oct 19, 2019

oktomus closed this Oct 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unified Viewport #2648

Unified Viewport #2648

fu5ha commented Jun 20, 2019 •

edited

Loading

dictoon left a comment

dictoon Sep 22, 2019

fu5ha Sep 24, 2019

dictoon Sep 25, 2019

dictoon Sep 22, 2019

oktomus left a comment •

edited

Loading

oktomus Sep 21, 2019

oktomus Sep 21, 2019

oktomus Sep 21, 2019

oktomus Sep 21, 2019

oktomus commented Oct 21, 2019

Unified Viewport #2648

Unified Viewport #2648

Conversation

fu5ha commented Jun 20, 2019 • edited Loading

dictoon left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oktomus left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oktomus commented Oct 21, 2019

fu5ha commented Jun 20, 2019 •

edited

Loading

oktomus left a comment •

edited

Loading