Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use out-of-place evaluation wherever possible #177

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Use out-of-place evaluation wherever possible #177

merged 9 commits into from
Dec 16, 2024

Conversation

hugary1995
Copy link
Collaborator

  • On-demand matrix assembly
  • Fix unit tests, regression tests, and verification tests
  • Add more model forward operator APIs
  • Refactor LabeledAxis
  • Update unit test and drivers to use the new model evaluation APIs

@hugary1995 hugary1995 marked this pull request as draft December 4, 2024 12:00
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Syntax check

No syntax error, good job! 💜

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024 •
edited
Loading

Documentation preview removed.
To view the documentation, please visit the main documentation page.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Test Results (macos-latest-Release-ON)

    3 files      3 suites   32s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 373 runs  3 373 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Test Results (macos-latest-Debug-ON)

    3 files      3 suites   1m 4s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Python Binding Test Results (macos-latest)

85 tests   61 ✅  3s ⏱️
 1 suites  24 💤
 1 files     0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Test Results (macos-latest-Debug-OFF)

    3 files      3 suites   1m 8s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Test Results (macos-latest-Release-OFF)

    3 files      3 suites   33s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 373 runs  3 373 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024 •
edited
Loading

Python Binding Test Results (ubuntu-latest)

83 tests   59 ✅  3s ⏱️
 1 suites  24 💤
 1 files     0 ❌

Results for commit 6e3865f.

♻️ This comment has been updated with latest results.

@hugary1995 hugary1995 force-pushed the outplace branch 2 times, most recently from 6f12bcb to 3cf65a7 Compare December 8, 2024 22:52
@hugary1995 hugary1995 self-assigned this Dec 9, 2024
@hugary1995 hugary1995 marked this pull request as ready for review December 9, 2024 01:16
@hugary1995 hugary1995 mentioned this pull request Dec 9, 2024
Closed
@hugary1995 hugary1995 force-pushed the outplace branch 4 times, most recently from bc1d5b3 to 68d751c Compare December 14, 2024 01:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Test Results (ubuntu-22.04-Release-ON)

    3 files      3 suites   1m 0s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 373 runs  3 373 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Test Results (ubuntu-22.04-Debug-ON)

    3 files      3 suites   2m 2s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Test Results (ubuntu-22.04-Release-OFF)

    3 files      3 suites   58s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 373 runs  3 373 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

Test Results (ubuntu-22.04-Debug-OFF)

    3 files      3 suites   2m 10s ⏱️
  559 tests   559 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2024 •
edited
Loading

Python Binding Test Results (ubuntu-22.04)

85 tests   61 ✅  7s ⏱️
 1 suites  24 💤
 1 files     0 ❌

Results for commit 199427c.

♻️ This comment has been updated with latest results.

@hugary1995
Copy link
Collaborator Author

This will also close #165 and #180

This was linked to issues Dec 15, 2024
More option metadata #165
Closed
freeze lookback for NEML2-Pyzag interface #180
Closed
@hugary1995 hugary1995 force-pushed the outplace branch 2 times, most recently from 729bfe9 to f26bbc0 Compare December 15, 2024 17:36
@reverendbedford @hugary1995
Make NEML2 use out-of-place evaluation wherever possible
edf2fb9 
- On-demand matrix assembly
- Fix unit tests, regression tests, and verification tests
- Add more model forward operator APIs
- Refactor LabeledAxis
- Update unit test and drivers to use the new model evaluation APIs
- Add new automatic differentiation APIs
- Regold (only) because of output format change
- Add bitmask operators
- Update python bindings
- Add new forward operator APIs that take map of tensors
- Replace LabeledTensor with Assemblers
- Improve python package visualization and add a unit test
- Update documentation to reflect all the changes
- Add NEML2_CPU_PROFILER to link libneml2 against libprofiler
- Factor out a common base class for solid mechanics drivers
- Add CystalMean object, remove taylor_average in the verification test
- Restrict the use of cp-warmup to strain-controlled large deformation incremental drivier
- Demangle include dependencies
- Switching to codechecker for linting
- Seprate out copyright check
- Ping pyzag version
@hugary1995
Copy link
Collaborator Author

I'm pretty sure this is my personal record in # line change.

reverendbedford
reverendbedford requested changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@reverendbedford reverendbedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several minor comments. The biggest request is to centralize the names of the "canonical" axes to make those easier to configure later on. Hopefully the detailed comments on this idea make it clear what I mean.

doc/content/system/model.md Outdated Show resolved Hide resolved
doc/content/system/model.md Outdated Show resolved Hide resolved
doc/content/system/model.md Outdated Show resolved Hide resolved
include/neml2/contrib/boost/bitmask_operators.h Outdated Show resolved Hide resolved
include/neml2/misc/math.h Show resolved Hide resolved
src/neml2/models/LabeledAxisAccessor.cxx Show resolved Hide resolved
src/neml2/models/LabeledAxisAccessor.cxx Show resolved Hide resolved
python/neml2/pyzag/interface.py Show resolved Hide resolved
python/neml2/pyzag/interface.py Show resolved Hide resolved
python/neml2/pyzag/interface.py Show resolved Hide resolved
@reverendbedford reverendbedford merged commit 19df224 into main Dec 16, 2024
23 checks passed
@reverendbedford reverendbedford deleted the outplace branch December 16, 2024 23:18
github-actions bot added a commit that referenced this pull request Dec 16, 2024
@github-actions
Remove preview for PR #177
1e0346b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reverendbedford reverendbedford reverendbedford approved these changes

Assignees

@hugary1995 hugary1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

freeze lookback for NEML2-Pyzag interface More option metadata
2 participants
@hugary1995 @reverendbedford