Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assign_output_derivative bug #192

Closed
wants to merge 3 commits into from
Closed

Conversation

hugary1995
Copy link
Collaborator

The std::map::insert does not replace the value if a key already exists. This prevents IFT from updating derivatives if the variable derivative cache is not cleared after every forward evaluation.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (macos-latest-Debug-ON)

    3 files      3 suites   58s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 377 runs  3 377 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (macos-latest-Release-ON)

    3 files      3 suites   31s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Syntax check

No syntax error, good job! 💜

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Documentation preview removed.
To view the documentation, please visit the main documentation page.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (ubuntu-22.04-Release-ON)

    3 files      3 suites   55s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Python Binding Test Results (macos-latest)

85 tests   61 ✅  4s ⏱️
 1 suites  24 💤
 1 files     0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (ubuntu-22.04-Debug-ON)

    3 files      3 suites   1m 49s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 377 runs  3 377 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (macos-latest-Debug-OFF)

    3 files      3 suites   58s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 377 runs  3 377 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Python Binding Test Results (ubuntu-22.04)

85 tests   61 ✅  7s ⏱️
 1 suites  24 💤
 1 files     0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (macos-latest-Release-OFF)

    3 files      3 suites   33s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (ubuntu-22.04-Release-OFF)

    3 files      3 suites   55s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 375 runs  3 375 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Test Results (ubuntu-22.04-Debug-OFF)

    3 files      3 suites   2m 2s ⏱️
  561 tests   561 ✅ 0 💤 0 ❌
3 377 runs  3 377 ✅ 0 💤 0 ❌

Results for commit 54dc36e.

♻️ This comment has been updated with latest results.

@hugary1995
Copy link
Collaborator Author

close in favor of #187 which is based on this

@hugary1995 hugary1995 closed this Dec 21, 2024
github-actions bot added a commit that referenced this pull request Dec 21, 2024
@hugary1995 hugary1995 deleted the assign_derivative branch December 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant