-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assign_output_derivative bug #192
Conversation
Test Results (macos-latest-Debug-ON) 3 files 3 suites 58s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (macos-latest-Release-ON) 3 files 3 suites 31s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Syntax checkNo syntax error, good job! 💜 |
Documentation preview removed. |
Test Results (ubuntu-22.04-Release-ON) 3 files 3 suites 55s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Python Binding Test Results (macos-latest)85 tests 61 ✅ 4s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (ubuntu-22.04-Debug-ON) 3 files 3 suites 1m 49s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (macos-latest-Debug-OFF) 3 files 3 suites 58s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Python Binding Test Results (ubuntu-22.04)85 tests 61 ✅ 7s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (macos-latest-Release-OFF) 3 files 3 suites 33s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (ubuntu-22.04-Release-OFF) 3 files 3 suites 55s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
Test Results (ubuntu-22.04-Debug-OFF) 3 files 3 suites 2m 2s ⏱️ Results for commit 54dc36e. ♻️ This comment has been updated with latest results. |
close in favor of #187 which is based on this |
The
std::map::insert
does not replace the value if a key already exists. This prevents IFT from updating derivatives if the variable derivative cache is not cleared after every forward evaluation.