Skip to content

Commit

Permalink
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
Browse files Browse the repository at this point in the history
…o chore/eject-cra-retry-3
  • Loading branch information
riodeuno committed Feb 12, 2025
2 parents 6502ee6 + 9aa065b commit 7fca371
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ describe(
agHelper.GetNClickByContains(dataSources._dropdownOption, "friends");

GenerateCRUDNValidateDeployPage(
"<p>Monica's old friend Rachel moves in with her after leaving her fiancé.</p>",
"Monica's old friend Rachel moves in with her after leaving her fiancé.",
`1994-09-22T00:00:00+00:00`,
"http://www.tvmaze.com/episodes/40646/friends-1x01-the-one-where-it-all-began",
11,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import {
COMMITTING_AND_PUSHING_CHANGES,
createMessage,
DISCARD_CHANGES,
DISCARD_SUCCESS,
DISCARDING_AND_PULLING_CHANGES,
GIT_NO_UPDATED_TOOLTIP,
PULL_CHANGES,
Expand Down Expand Up @@ -239,7 +240,7 @@ function TabDeployView({
AnalyticsUtil.logEvent("GIT_DISCARD", {
source: "GIT_DISCARD_BUTTON_PRESS_2",
});
discard(createMessage(DISCARD_CHANGES));
discard(createMessage(DISCARD_SUCCESS));
setShowDiscardWarning(false);
setShouldDiscard(true);
setIsDiscarding(true);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -363,15 +363,14 @@ private Set<String> populateHintMessages(List<String> columnNames) {
@Override
public Mono<HikariDataSource> datasourceCreate(DatasourceConfiguration datasourceConfiguration) {
log.debug(Thread.currentThread().getName() + ": datasourceCreate() called for MSSQL plugin.");
return connectionPoolConfig
.getMaxConnectionPoolSize()
.flatMap(maxPoolSize -> {
return Mono.defer(
() -> connectionPoolConfig.getMaxConnectionPoolSize().flatMap(maxPoolSize -> {
return Mono.fromCallable(() -> {
log.debug(Thread.currentThread().getName() + ": Connecting to SQL Server db");
return createConnectionPool(datasourceConfiguration, maxPoolSize);
});
})
.subscribeOn(scheduler);
log.debug(Thread.currentThread().getName() + ": Connecting to SQL Server db");
return createConnectionPool(datasourceConfiguration, maxPoolSize);
})
.subscribeOn(scheduler);
}));
}

@Override
Expand Down

0 comments on commit 7fca371

Please sign in to comment.