Code cleanup.

appunite · May 9, 2024 · 6f06ca4 · 6f06ca4
1 parent f17b38f
commit 6f06ca4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt b/app-shared-tests/src/main/java/com/appunite/loudius/AbsReviewersScreenTest.kt
@@ -26,13 +26,17 @@ import com.appunite.loudius.ui.reviewers.ReviewersScreen
 import com.appunite.loudius.util.IntegrationTestRule
 import com.appunite.loudius.util.Register
 import com.appunite.loudius.util.waitUntilLoadingDoesNotExist
+import com.appunite.mockwebserver_assertions.path
+import com.appunite.mockwebserver_assertions.url
 import com.appunite.mockwebserverextensions.MockWebServerRule
+import okhttp3.mockwebserver.MockResponse
 import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 import org.koin.compose.KoinContext
 import strikt.api.expectThat
 import strikt.assertions.containsExactly
+import strikt.assertions.isEqualTo
 
 abstract class AbsReviewersScreenTest {
 
@@ -111,7 +115,14 @@ abstract class AbsReviewersScreenTest {
     @Test
     fun whenClickOnNotifyAndDoNotCommentThenShowError() {
         with(integrationTestRule) {
-            Register.set404Error(mockWebServer)
+            mockWebServer.register {
+                expectThat(it).url.and {
+                    get("host") { host }.isEqualTo("api.github.com")
+                    path.isEqualTo("/repos/exampleOwner/exampleRepo/issues/1/comments")
+                }
+
+                MockResponse().setResponseCode(404)
+            }
 
             composeTestRule.setContent {
                 KoinContext {

diff --git a/app-shared-tests/src/main/java/com/appunite/loudius/util/Register.kt b/app-shared-tests/src/main/java/com/appunite/loudius/util/Register.kt
@@ -21,7 +21,6 @@ import com.appunite.mockwebserver_assertions.queryParameter
 import com.appunite.mockwebserver_assertions.url
 import com.appunite.mockwebserverextensions.MockWebServerRule
 import com.appunite.mockwebserverextensions.util.jsonResponse
-import okhttp3.mockwebserver.MockResponse
 import strikt.api.expectThat
 import strikt.assertions.isEqualTo
 
@@ -103,17 +102,6 @@ object Register {
         }
     }
 
-    fun set404Error(mockWebServer: MockWebServerRule) {
-        mockWebServer.register {
-            expectThat(it).url.and {
-                get("host") { host }.isEqualTo("api.github.com")
-                path.isEqualTo("/repos/exampleOwner/exampleRepo/issues/1/comments")
-            }
-
-            MockResponse().setResponseCode(404)
-        }
-    }
-
     fun requestedReviewers(mockWebServer: MockWebServerRule) {
         mockWebServer.register {
             expectThat(it).url.and {