-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LD-147] Add merged code coverage. #201
Conversation
Unit tests code coverage
|
E2E code coverage
|
Merged code coverage
|
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
'**/R.class', | ||
'**/R$*.class', | ||
'**/BuildConfig.*', | ||
"**/*Application.*", | ||
'**/Manifest*.*', | ||
'**/*Test*.*', | ||
'**/android/**/*.*', | ||
'**/androidx/**/*.*', | ||
'**/airbnb/**/*.*', | ||
"**/di/**/*.*", | ||
'**/*Dagger*.*', | ||
"**/*Screen*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out-of-scope: We should probably adjust now, those exclude. I.e.
"**/*Application.*",
shuldn't be excluded, because we test application"**/di/**/*.*"
shuldn't be excluded, because we test it- `"**/Screen" shuldn't be excluded, because we test it
'**/*Dagger*.*',
- we don't use dagger ;)'**/android/**/*.*
,**/androidx/**/*.*
and'**/*Test*.*'
are excluded, but doesn't make sense, because those files aren't included in"**/tmp/kotlin-classes/debug/**"
But: ShowkaseRoot
, ShowkaseRootCodegen
and ShowkaseRootShowkaseExcetionsFunctionsCodegenKt
could be excluded from the report,
out-of-scope: In the report, files from the components
module (com.appunite.loudius.components.components) aren't included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Task added!
|
Pull-Request
Description
Why?
We want to have merged coverage report for both - Unit Test and E2E tests.
What?
Added merged coverage report.
Links to related issues
Demo
How to test
You can delete some tests and check the coverage.
or
./gradlew testDebugUnitTest
./gradlew codeCoverage
Documentation
Checklist
- [ ] Functionality is covered by unit tests- [ ] Functionality is covered by integration tests