Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-161] Add coverage for components module and update excluded dirs. #203

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Feb 6, 2024

Pull-Request

Description

Why?

We want to measure test coverage for entire project.

What?

Added measure coverage for components module and update excluded dirs.

Links to related issues

Demo

Screenshot 2024-02-06 at 12 01 07

How to test

Download the code-coverage artifact from GitHub CI and open it. You can see coverage for both - app module and components module. If you want, you can calculate the expected coverage for them and compare with our result, which is 73.13%. (I did it and it's correct ;))

Documentation

Links to helpers:

Checklist

- [ ] Functionality is covered by unit tests
- [ ] Functionality is covered by integration tests

  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

github-actions bot commented Feb 6, 2024

Overall Project 86.84% 🍏

There is no coverage information present for the Files changed

Copy link

github-actions bot commented Feb 6, 2024

Overall Project 73.13%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika changed the title Add coverage for components module. [LD-161] Add coverage for components module and update excluded dirs. Feb 6, 2024
@nowakweronika nowakweronika marked this pull request as ready for review February 6, 2024 11:10
Copy link

github-actions bot commented Feb 8, 2024

Overall Project 73.13%

There is no coverage information present for the Files changed

Copy link
Member

@jacek-marchwicki jacek-marchwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

github-actions bot commented Feb 8, 2024

Overall Project 73.2%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika merged commit 086127b into develop Feb 9, 2024
10 checks passed
@nowakweronika nowakweronika deleted the feature/exclude_dirs_from_codeCoverage branch February 9, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants