-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LD-142] Fix slack notifications #205
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nowakweronika
changed the title
Fix: Change name from master to main.
[LD-142] Fix slack notifications
Feb 13, 2024
|
jacek-marchwicki
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please do squash instead of merge, because there is a lot of useless commits ;p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-Request
Description
Why?
We want to be aware of any failed job on the develop and main branches.
What?
Added relevant condition to the Include Slack Notification step.
Links to related issues
Demo
How to test
name: Run tests on Firebase Test Lab run: |- gcloud firebase test android run \ --app="app/build/outputs/apk/debug/app-debug.apk" \ --test="app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk" \ --device="model=Pixel2.arm,version=33,locale=en,orientation=portrait" \ --type=instrumentation \ --use-orchestrator \ --test-runner-class="com.appunite.loudius.util.InstrumentationTestRunner" \ --timeout="20m" \ --results-dir="${{ steps.generate-dir.outputs.results_dir }}" \ --results-bucket="${{ steps.generate-dir.outputs.bucket }}" \ --environment-variables "clearPackageData=true,coverage=true,coverageFilePath=/sdcard/Download/" \ --directories-to-pull /sdcard/Download + exit 1
Documentation
Checklist
- [ ] Functionality is covered by unit tests- [ ] Functionality is covered by integration tests