Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LD-142] Fix slack notifications #205

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Conversation

nowakweronika
Copy link
Collaborator

@nowakweronika nowakweronika commented Feb 12, 2024

Pull-Request

Description

Why?

We want to be aware of any failed job on the develop and main branches.

What?

Added relevant condition to the Include Slack Notification step.

Links to related issues

Demo

Screenshot 2024-02-13 at 15 14 32

How to test

  • Step 1: Add "exit 1" to any step in one of the job which is mentioned in needs context in test-results job. Example:
name: Run tests on Firebase Test Lab
  run: |-
    gcloud firebase test android run \
      --app="app/build/outputs/apk/debug/app-debug.apk" \
      --test="app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk" \
      --device="model=Pixel2.arm,version=33,locale=en,orientation=portrait" \
      --type=instrumentation \
      --use-orchestrator \
      --test-runner-class="com.appunite.loudius.util.InstrumentationTestRunner" \
      --timeout="20m" \
      --results-dir="${{ steps.generate-dir.outputs.results_dir }}" \
      --results-bucket="${{ steps.generate-dir.outputs.bucket }}" \
      --environment-variables "clearPackageData=true,coverage=true,coverageFilePath=/sdcard/Download/" \
      --directories-to-pull /sdcard/Download
+    exit 1
  • Expected: After test-results job finished, you should be able to see relevant message on loudius-internal slack channel.

Documentation

Checklist

- [ ] Functionality is covered by unit tests
- [ ] Functionality is covered by integration tests

  • I've updated PR description with relevant information
  • I've done self code review
  • I've manually tested if the code and app works

Copy link

Overall Project 73.2%

There is no coverage information present for the Files changed

Copy link

Overall Project 73.2%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika changed the title Fix: Change name from master to main. [LD-142] Fix slack notifications Feb 13, 2024
Copy link

Overall Project 73.2%

There is no coverage information present for the Files changed

@nowakweronika nowakweronika marked this pull request as ready for review February 13, 2024 14:22
Copy link
Member

@jacek-marchwicki jacek-marchwicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please do squash instead of merge, because there is a lot of useless commits ;p

@nowakweronika nowakweronika merged commit 6dd7468 into develop Feb 14, 2024
12 of 14 checks passed
@nowakweronika nowakweronika deleted the fix/slack_notifications branch February 15, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants