tests: fix tab selectors

appwrite · Jul 22, 2024 · 8325295 · 8325295
1 parent 717b80a
commit 8325295
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/lib/components/secondaryTabsItem.svelte b/src/lib/components/secondaryTabsItem.svelte
@@ -28,7 +28,6 @@
         {/if}
     {:else}
         <button
-            role="tab"
             type="button"
             class="secondary-tabs-button"
             class:u-width-full-line={fullWidth}

diff --git a/tests/unit/components/dropTabsItem.test.ts b/tests/unit/components/dropTabsItem.test.ts
@@ -3,10 +3,10 @@ import { vi } from 'vitest';
 import { render, fireEvent } from '@testing-library/svelte';
 import { SecondaryTabsItem } from '../../../src/lib/components';
 
-test('shows button', () => {
+test('shows tab', () => {
     const { getByRole } = render(SecondaryTabsItem);
 
-    expect(getByRole('button')).toBeInTheDocument();
+    expect(getByRole('tab')).toBeInTheDocument();
 });
 
 test('shows link', () => {

diff --git a/tests/unit/components/tab.test.ts b/tests/unit/components/tab.test.ts
@@ -11,7 +11,7 @@ test('shows tab', () => {
 test('shows tab - is selected', () => {
     const { getByRole } = render(Tab, { selected: true });
 
-    expect(getByRole('tab')).toHaveClass('is-selected');
+    expect(getByRole('tab').querySelector('button')).toHaveClass('is-selected');
 });
 
 test('shows tab - is link', () => {
@@ -23,7 +23,7 @@ test('shows tab - is link', () => {
 
 test('shows tab - on:click', async () => {
     const { getByRole, component } = render(Tab);
-    const tab = getByRole('tab');
+    const tab = getByRole('tab').querySelector('button');
     const callback = vi.fn();
     component.$on('click', callback);