Merge branch '1.6.x' of github.com:appwrite/console into fix-design-1.6

appwrite · Jul 22, 2024 · 935cadd · 935cadd
2 parents 8733973 + d60f77a
commit 935cadd
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/src/lib/components/secondaryTabsItem.svelte b/src/lib/components/secondaryTabsItem.svelte
@@ -28,7 +28,6 @@
         {/if}
     {:else}
         <button
-            role="tab"
             type="button"
             class="secondary-tabs-button"
             class:u-width-full-line={fullWidth}

diff --git a/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte b/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte
@@ -202,8 +202,7 @@
         <div class="common-section">
             <Alert type="info" isStandalone>
                 <svelte:fragment slot="title">Your execution logs are disabled</svelte:fragment>
-
-                To see the latest execution logs, enable them in your
+                To view execution logs and errors, enable them in your
                 <a
                     href={`${base}/project-${$project.$id}/functions/function-${$func.$id}/settings`}
                     class="link">

diff --git a/...s/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte b/...s/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte
@@ -69,15 +69,15 @@
     <CardGrid>
         <Heading tag="h6" size="7">Execution logs</Heading>
         <p>
-            Enable or disable execution logs. We recommend disabling logs when transferring critical
-            data or for performance reasons.
+            Enable or disable execution logs. We recommend disabling them for better performance in
+            production.
         </p>
         <svelte:fragment slot="aside">
             <FormList>
                 <InputSwitch label="Logs" id="logging" bind:value={functionLogging}>
                     <svelte:fragment slot="description">
                         <p>
-                            When enabled, all execution responses will be accessible in the <a
+                            When disabled, execution logs and errors will not be shown in the <a
                                 href={`${base}/project-${$project.$id}/functions/function-${$func.$id}/executions`}
                                 class="link">
                                 Executions</a> tab

diff --git a/tests/unit/components/dropTabsItem.test.ts b/tests/unit/components/dropTabsItem.test.ts
@@ -3,10 +3,10 @@ import { vi } from 'vitest';
 import { render, fireEvent } from '@testing-library/svelte';
 import { SecondaryTabsItem } from '../../../src/lib/components';
 
-test('shows button', () => {
+test('shows tab', () => {
     const { getByRole } = render(SecondaryTabsItem);
 
-    expect(getByRole('button')).toBeInTheDocument();
+    expect(getByRole('tab')).toBeInTheDocument();
 });
 
 test('shows link', () => {

diff --git a/tests/unit/components/tab.test.ts b/tests/unit/components/tab.test.ts
@@ -11,7 +11,7 @@ test('shows tab', () => {
 test('shows tab - is selected', () => {
     const { getByRole } = render(Tab, { selected: true });
 
-    expect(getByRole('tab')).toHaveClass('is-selected');
+    expect(getByRole('tab').querySelector('button')).toHaveClass('is-selected');
 });
 
 test('shows tab - is link', () => {
@@ -23,7 +23,7 @@ test('shows tab - is link', () => {
 
 test('shows tab - on:click', async () => {
     const { getByRole, component } = render(Tab);
-    const tab = getByRole('tab');
+    const tab = getByRole('tab').querySelector('button');
     const callback = vi.fn();
     component.$on('click', callback);