Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My proposal for a new interface of the Aptos Wallet Adapter.
Key objectives:
Changes in
core
package:AdaptedWallet
class, that will take as an input a wallet interface with minimum required features and expose a unified and clean interface for accessing it. Internally, this class performs feature version negotiation, ensuring we're using the most up-to-date version or fallback to older but still compatible versions.WalletAdapter
).walletFromLegacyPlugin
so that dapps that rely on legacy plugins can still use the new interface (all required features need to be supported)Changes in
react
package:useActiveWallet
has different states. Union discrimination enables intuitive and expressive access to features based on the current state.example:
TODO:
react
package and showcase it's expressivenesss