Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve page hiding for subgraph docs #164

Merged
merged 3 commits into from
Apr 18, 2024
Merged

Conversation

banasa44
Copy link
Contributor

@banasa44 banasa44 commented Apr 16, 2024

Description

We hid pages from the sidebar but they were still visible in the pagination next/prev buttons.

Add pagination_nex/prev to jump to the desired pages and keep hid pages fully hidden.

Task: OS-1147

@banasa44 banasa44 requested review from Rekard0 and heueristik April 16, 2024 13:36
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a typo. Apart from that, good to go 👍

Co-authored-by: Michael Heuer <[email protected]>
@banasa44 banasa44 requested a review from heueristik April 18, 2024 11:18
@banasa44 banasa44 merged commit 3ea9d21 into staging Apr 18, 2024
2 checks passed
@banasa44 banasa44 deleted the fix/improve-page-hiding branch April 18, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants