Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add versioning #165

Closed
wants to merge 3 commits into from
Closed

feat: add versioning #165

wants to merge 3 commits into from

Conversation

banasa44
Copy link
Contributor

@banasa44 banasa44 commented Apr 22, 2024

Description

Add versions to our Docusaurus documentation site.
Remove staging-temp functionality.
Created a 1.3.0 snapshot version of our current documentation. Deleted there the subgraph docs as we don't want them to live in the v1.3.0.

To properly review this PR.

  • Please ignore all .md and .mdx files.
  • Review just the first file: /workflows/publish-on-fleek.yaml,
  • take into account renaming: fleek_staging.json (see first commit separately)
  • Review docusaurus.config.js.
  • The commented-out code regarding versioning has been left like this waiting to create a PR template to remind people to comment this code out when merging staging -> master. In staging shouldn't be commented out for testing purposes.

Task: OS-1276

@banasa44 banasa44 requested review from Rekard0 and heueristik April 22, 2024 15:06
@heueristik heueristik changed the title Feat: Add versioning feat: add versioning Apr 25, 2024
Comment on lines +36 to +37
// label: '1.4.1',
// path: '1.4.1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// label: '1.4.1',
// path: '1.4.1',
// label: '1.4.0',
// path: '1.4.0',

@@ -152,7 +168,7 @@ const config = {
rootPath: './docs',
baseURL: 'subgraph/reference-guide',
homepage: './static/subgraph/index.md',
linkRoot: '/docs',
linkRoot: '/docs/next',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why next? could you explain for knowledge purposes

</div>
</foreignObject>
<text x="50" y="44" fill="rgb(0, 0, 0)" font-family="Helvetica" font-size="12px" text-anchor="middle">
</text></switch><rect width="120" height="130" x="40" y="40" fill="#FFF" stroke="#000" pointer-events="all" rx="18" ry="18"/><rect width="40" height="20" x="30" y="30" fill="#FFF" stroke="#000" pointer-events="all" rx="3" ry="3"/><switch transform="translate(-.5 -.5)"><foreignObject width="100%" height="100%" pointer-events="none" requiredFeatures="http://www.w3.org/TR/SVG11/feature#Extensibility" style="overflow:visible;text-align:left"><div xmlns="http://www.w3.org/1999/xhtml" style="display:flex;align-items:unsafe center;justify-content:unsafe center;width:38px;height:1px;padding-top:40px;margin-left:31px"><div data-drawio-colors="color: rgb(0, 0, 0);" style="box-sizing:border-box;font-size:0;text-align:center"><div style="display:inline-block;font-size:12px;font-family:Helvetica;color:#000;line-height:1.2;pointer-events:all;white-space:normal;overflow-wrap:normal">0x54...</div></div></div></foreignObject><text x="50" y="44" font-family="Helvetica" font-size="12" text-anchor="middle">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i only comment here thses auto or generated file should not be commited into PRs more than once

we need to find a different way to deal with them

@banasa44 banasa44 closed this Apr 30, 2024
@banasa44 banasa44 deleted the feat/add-versioning branch April 30, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants