chore: resolve PR convos -- changelog, mapping name

aragon · Jan 23, 2025 · 54f15df · 54f15df
1 parent f3202a0
commit 54f15df
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Added
 
-- Add `size` prop to `<Dialog /` with `max-w` t-shirt sizing for responsiveness based on viewport
+- Add `size` prop to `<Dialog />` core component with `max-w` t-shirt sizing
 
 ### Changed
 

diff --git a/src/core/components/dialogs/dialog/dialogRoot/dialogRoot.tsx b/src/core/components/dialogs/dialog/dialogRoot/dialogRoot.tsx
@@ -5,7 +5,7 @@ import { AnimatePresence, motion } from 'framer-motion';
 import { dialogContentAnimationVariants, dialogOverlayAnimationVariants } from '../../dialogUtils';
 import type { DialogSize, IDialogRootProps } from './dialogRoot.api';
 
-const responsiveSizeClassNames: Record<DialogSize, string> = {
+const sizeToClassNames: Record<DialogSize, string> = {
     sm: 'max-w-[400px]',
     md: 'max-w-[480px]',
     lg: 'max-w-[640px]',
@@ -40,7 +40,7 @@ export const DialogRoot: React.FC<IDialogRootProps> = (props) => {
         'fixed inset-x-2 bottom-2 mx-auto max-h-[calc(100vh-80px)] overflow-auto md:inset-x-6 md:bottom-6 lg:bottom-auto lg:top-12 lg:max-h-[calc(100vh-200px)]',
         'flex flex-col rounded-xl border border-neutral-100 bg-neutral-0 shadow-neutral-md',
         'z-[var(--guk-dialog-content-z-index)]',
-        responsiveSizeClassNames[size],
+        sizeToClassNames[size],
         containerClassName,
     );