Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-3094 - Update ProposalDataListItemStrucure component #147

Merged

Conversation

Fabricevladimir
Copy link
Contributor

@Fabricevladimir Fabricevladimir commented Apr 19, 2024

Description

  • Add stageId and stageTitle properties to IApprovalThresholdResult & IMajorityVotingResult interfaces
  • Add id and optional tag properties to ProposalDataListItemStructure
  • Remove publisherProfileLink and protocolUpdate properties from ProposalDataListItemStructure
  • Update date and result properties of ProposalDataListItemStructure to be optional and publisher to allow for
    multiple publishers
  • Fixed Link core component children to truncate properly when overflowing

Task: APP-3094

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@Fabricevladimir Fabricevladimir requested a review from a team April 19, 2024 12:26
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @Fabricevladimir!

@cgero-eth cgero-eth changed the title Feat: APP-3094 - Update ProposalDataListItemStrucure feat: APP-3094 - Update ProposalDataListItemStrucure component Apr 23, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @Fabricevladimir! ✅

@Fabricevladimir Fabricevladimir force-pushed the feat-APP-3094-update-proposalDataListItemStrucure branch from 1229c9a to 6a25a35 Compare April 23, 2024 11:44
@Fabricevladimir Fabricevladimir merged commit 1a9cb09 into main Apr 23, 2024
4 checks passed
@Fabricevladimir Fabricevladimir deleted the feat-APP-3094-update-proposalDataListItemStrucure branch April 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants