-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-3094 - Update ProposalDataListItemStrucure component #147
Merged
Fabricevladimir
merged 29 commits into
main
from
feat-APP-3094-update-proposalDataListItemStrucure
Apr 23, 2024
Merged
feat: APP-3094 - Update ProposalDataListItemStrucure component #147
Fabricevladimir
merged 29 commits into
main
from
feat-APP-3094-update-proposalDataListItemStrucure
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgero-eth
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @Fabricevladimir!
...osal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.api.ts
Outdated
Show resolved
Hide resolved
...nents/proposal/proposalDataListItem/approvalThresholdResult/approvalThresholdResult.test.tsx
Outdated
Show resolved
Hide resolved
...nents/proposal/proposalDataListItem/approvalThresholdResult/approvalThresholdResult.test.tsx
Outdated
Show resolved
Hide resolved
...components/proposal/proposalDataListItem/approvalThresholdResult/approvalThresholdResult.tsx
Outdated
Show resolved
Hide resolved
.../components/proposal/proposalDataListItem/majorityVotingResult/majorityVotingResult.test.tsx
Outdated
Show resolved
Hide resolved
...osal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.api.ts
Outdated
Show resolved
Hide resolved
...al/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.test.tsx
Outdated
Show resolved
Hide resolved
...roposal/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.tsx
Outdated
Show resolved
Hide resolved
...al/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.test.tsx
Outdated
Show resolved
Hide resolved
...al/proposalDataListItem/proposalDataListItemStructure/proposalDataListItemStructure.test.tsx
Outdated
Show resolved
Hide resolved
cgero-eth
changed the title
Feat: APP-3094 - Update ProposalDataListItemStrucure
feat: APP-3094 - Update ProposalDataListItemStrucure component
Apr 23, 2024
cgero-eth
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @Fabricevladimir! ✅
Fabricevladimir
force-pushed
the
feat-APP-3094-update-proposalDataListItemStrucure
branch
from
April 23, 2024 11:44
1229c9a
to
6a25a35
Compare
Fabricevladimir
deleted the
feat-APP-3094-update-proposalDataListItemStrucure
branch
April 23, 2024 11:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stageId
andstageTitle
properties toIApprovalThresholdResult
&IMajorityVotingResult
interfacesid
and optionaltag
properties toProposalDataListItemStructure
publisherProfileLink
andprotocolUpdate
properties fromProposalDataListItemStructure
date
andresult
properties ofProposalDataListItemStructure
to be optional andpublisher
to allow formultiple publishers
Link
core component children to truncate properly when overflowingTask: APP-3094
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.