-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix responsiveness classes and utilities to support style for screens below sm breakpoint #199
Conversation
3653bf3
to
35ed860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think anything circular needs the shrink help from what I've noticed.
Icon test id example (button):
<svg
class="shrink-0 size-4 transition-all group-aria-disabled:text-neutral-300 text-neutral-0"
data-testid="CHECKMARK"
/>
return ( | ||
<IconComponent | ||
className={classNames('shrink-0', sizeClassNames, className)} | ||
data-testid={icon} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons already have a testid on the SVG per file I believe? It's the name of the icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yess, it already works internally on the ods
library because we transform svgs into React components with test-ids through the /core/test/svgTransform.js
file. The data-testid
is needed for applications using the ods
library (app-next) because the svgs are bundled into the library and cannot be transformed as we already do on the library itself. Good point though 👌🏻
src/core/components/states/stateSkeletonCircular/stateSkeletonCircular.tsx
Show resolved
Hide resolved
078ca94
to
e035ab0
Compare
Description
shrink-0
class nameType of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.