Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(APP-2883): Move all form items under a forms folder #214

Merged
merged 2 commits into from
Jun 20, 2024
Merged

refactor(APP-2883): Move all form items under a forms folder #214

merged 2 commits into from
Jun 20, 2024

Conversation

rcaragon
Copy link
Contributor

@rcaragon rcaragon commented Jun 19, 2024 •
edited by jira bot
Loading

Description

Move all form items under a form folder to reflect the Figma structure.

Task: APP-2883

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@rcaragon rcaragon marked this pull request as ready for review June 19, 2024 07:46
@rcaragon rcaragon requested a review from a team June 19, 2024 07:47
@cgero-eth cgero-eth changed the title Refactor (APP-2883): Move all form items under a forms folder refactor(APP-2883): Move all form items under a forms folder Jun 19, 2024
thekidnamedkd
thekidnamedkd approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just have that one question about hooks home before you merge. Nice work! ✨

src/core/components/forms/hooks/index.ts Show resolved Hide resolved
@cgero-eth cgero-eth merged commit eca83b2 into main Jun 20, 2024
3 checks passed
@cgero-eth cgero-eth deleted the refactor/forms branch June 20, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth left review comments

@thekidnamedkd thekidnamedkd thekidnamedkd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rcaragon @cgero-eth @thekidnamedkd