-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(APP-3310): Upgrade Storybook to v8 #215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcaragon thanks for the implementation. Excited for this. Left a few questions and comments. ✨
2d54d37
to
c46eff4
Compare
Let's keep an eye on these addons dependencies. It seems non-blocking for now. Good point @thekidnamedkd, @rcaragon could you have a look at this before merging the PR? |
Let's keep an eye on these addons dependencies. It seems non-blocking for now. Migrated to an up-to-date addon ad73f7a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. I'm still seeing the warning about github flavored markdown package as a migration tool. Again, non-blocking but there's a migration guide for this as well?
It appears that we don't need that addon, removed here: adf7621 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you both @rcaragon & @thekidnamedkd!
Description
Upgrade Storybook to v8.
Task: APP-3310
Checklist:
CHANGELOG.md
file in the root folder of the package after the [UPCOMING] title and beforethe latest version.