Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-3310): Upgrade Storybook to v8 #215

Merged
merged 10 commits into from
Jun 21, 2024
Merged

Conversation

rcaragon
Copy link
Contributor

@rcaragon rcaragon commented Jun 20, 2024

Description

Upgrade Storybook to v8.

Task: APP-3310

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@rcaragon rcaragon marked this pull request as ready for review June 20, 2024 07:23
@rcaragon rcaragon requested a review from a team June 20, 2024 07:24
package.json Outdated Show resolved Hide resolved
@rcaragon rcaragon changed the title Feat/upgrade storybook feat (APP-3310): Upgrade Storybook to v8 Jun 20, 2024
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rcaragon thanks for the implementation. Excited for this. Left a few questions and comments. ✨

.babelrc.json Show resolved Hide resolved
.storybook/main.ts Outdated Show resolved Hide resolved
.storybook/main.ts Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
.storybook/preview.tsx Show resolved Hide resolved
@cgero-eth cgero-eth changed the title feat (APP-3310): Upgrade Storybook to v8 feat(APP-3310): Upgrade Storybook to v8 Jun 20, 2024
@rcaragon rcaragon force-pushed the feat/upgrade-storybook branch from 2d54d37 to c46eff4 Compare June 20, 2024 12:03
@rcaragon rcaragon requested a review from thekidnamedkd June 20, 2024 12:04
thekidnamedkd
thekidnamedkd previously approved these changes Jun 20, 2024
@thekidnamedkd
Copy link
Contributor

image

Let's keep an eye on these addons dependencies. It seems non-blocking for now.

@cgero-eth
Copy link
Member

image Let's keep an eye on these addons dependencies. It seems non-blocking for now.

Good point @thekidnamedkd, @rcaragon could you have a look at this before merging the PR?

@rcaragon
Copy link
Contributor Author

image Let's keep an eye on these addons dependencies. It seems non-blocking for now.

Good point @thekidnamedkd, @rcaragon could you have a look at this before merging the PR?

Migrated to an up-to-date addon ad73f7a

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. I'm still seeing the warning about github flavored markdown package as a migration tool. Again, non-blocking but there's a migration guide for this as well?

@rcaragon
Copy link
Contributor Author

Awesome work. I'm still seeing the warning about github flavored markdown package as a migration tool. Again, non-blocking but there's a migration guide for this as well?

It appears that we don't need that addon, removed here: adf7621

@rcaragon rcaragon requested a review from thekidnamedkd June 21, 2024 07:27
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thank you both @rcaragon & @thekidnamedkd!

@cgero-eth cgero-eth merged commit 75d48a4 into main Jun 21, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat/upgrade-storybook branch June 21, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants