Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3202): Ensure MemberAvatar component works on server environments #217

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Jun 20, 2024

Description

  • Update MemberAvatar component to only call the blockies.create utility on client side
  • Implement ssr-utils to check current environment
  • Update MemberDataListItem component to accept votingpower set as string

Task: APP-3202

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team June 20, 2024 10:34
@cgero-eth cgero-eth force-pushed the fix-fix-memer-avatar-ssr-update-member-datalistitem branch from 5b0aed5 to 781b344 Compare June 21, 2024 07:57
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@cgero-eth cgero-eth force-pushed the fix-fix-memer-avatar-ssr-update-member-datalistitem branch from a3e7bed to e63f148 Compare June 21, 2024 14:23
@cgero-eth cgero-eth merged commit 81af13c into main Jun 21, 2024
4 checks passed
@cgero-eth cgero-eth deleted the fix-fix-memer-avatar-ssr-update-member-datalistitem branch June 21, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants