Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(APP-2885): Remove Radix props dependency #218

Merged
merged 18 commits into from
Jun 24, 2024
Merged

Conversation

rcaragon
Copy link
Contributor

@rcaragon rcaragon commented Jun 21, 2024

Description

Remove Radix props dependency.

Task: APP-2885

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@rcaragon rcaragon changed the title WIP: radix props Feat (APP-2885): Remove Radix props dependency Jun 21, 2024
@rcaragon rcaragon marked this pull request as ready for review June 21, 2024 10:37
@rcaragon rcaragon requested a review from a team June 21, 2024 10:37
@cgero-eth
Copy link
Member

PR name should be feat(APP-2885) and not Feat (APP-2885) 🙏🏻

Subject line must be prefixed with a lowercase type (fix, feat, ..) followed by a colon and a space.

From doc page

@rcaragon rcaragon changed the title Feat (APP-2885): Remove Radix props dependency Feat(APP-2885): Remove Radix props dependency Jun 21, 2024
@rcaragon
Copy link
Contributor Author

PR name should be feat(APP-2885) and not Feat (APP-2885) 🙏🏻

Subject line must be prefixed with a lowercase type (fix, feat, ..) followed by a colon and a space.

From doc page

Oops, fixed

@rcaragon rcaragon changed the title Feat(APP-2885): Remove Radix props dependency feat(APP-2885): Remove Radix props dependency Jun 21, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @rcaragon!

src/core/components/tabs/tabsContent/tabsContent.tsx Outdated Show resolved Hide resolved
src/core/components/tabs/tabsContent/tabsContent.tsx Outdated Show resolved Hide resolved
src/core/components/dropdown/dropdownItem/dropdownItem.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rcaragon rcaragon requested a review from cgero-eth June 23, 2024 08:57
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog still needs to be updated, the new entry should go under the unreleased header

@rcaragon
Copy link
Contributor Author

The changelog still needs to be updated, the new entry should go under the unreleased header

e112e26

@rcaragon rcaragon requested a review from cgero-eth June 24, 2024 11:51
@cgero-eth cgero-eth merged commit b7dcf65 into main Jun 24, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat/radix-props branch June 24, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants