Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(APP-3358): Implement ProposalActionTokenMint action #246

Merged
merged 2 commits into from
Jul 23, 2024
Merged

feat(APP-3358): Implement ProposalActionTokenMint action #246

merged 2 commits into from
Jul 23, 2024

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Jul 19, 2024 •
edited by jira bot
Loading

Description

Implement token mint proposal action type

Task: APP-3358

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@shan8851 shan8851 requested a review from cgero-eth July 19, 2024 05:24
cgero-eth
cgero-eth reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @shan8851!

...onents/member/memberDataListItem/memberDataListItemStructure/memberDataListItemStructure.tsx Outdated Show resolved Hide resolved
src/modules/types/tokenMintMetadataReceiver.ts Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActionsTypes/proposalActionTokenMint.ts Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/actions/mocks/proposalActionTokenMint.ts Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/actions/proposalActionTokenMint/index.ts Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
Base automatically changed from feat/APP-3059 to main July 22, 2024 16:51
@thekidnamedkd thekidnamedkd changed the title feat(APP-3358): Implement token mint proposal action type feat(APP-3358): Implement ProposalActionTokenMint action Jul 23, 2024
thekidnamedkd
thekidnamedkd reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thank you for staying on all the edits upstream. The base module is in main, should be no more rebasing from the other feature 🙌😅

...s/member/memberDataListItem/memberDataListItemStructure/memberDataListItemStructure.test.tsx Show resolved Hide resolved
...ts/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.test.tsx Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActions/proposalActions.stories.tsx Outdated Show resolved Hide resolved
@shan8851 shan8851 marked this pull request as ready for review July 23, 2024 10:13
cgero-eth
cgero-eth reviewed Jul 23, 2024
View reviewed changes
src/modules/components/proposal/proposalActions/proposalActionsUtils.ts Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActionsUtils.test.tsx Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActionsTypes/proposalActionType.ts Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActionsTypes/proposalActionTokenMint.ts Outdated Show resolved Hide resolved
src/modules/components/proposal/proposalActions/proposalActions/proposalActions.stories.tsx Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
...ponents/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.tsx Outdated Show resolved Hide resolved
...ts/proposal/proposalActions/actions/proposalActionTokenMint/proposalActionTokenMint.test.tsx Outdated Show resolved Hide resolved
cgero-eth
cgero-eth previously approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @shan8851!

@cgero-eth cgero-eth merged commit d044446 into main Jul 23, 2024
4 checks passed
@cgero-eth cgero-eth deleted the feat/APP-3358 branch July 23, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thekidnamedkd thekidnamedkd thekidnamedkd left review comments

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shan8851 @cgero-eth @thekidnamedkd