Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor fixes on Wallet component, support custom avatar on modules components #260

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

cgero-eth
Copy link
Member

Description

  • Update ICompositeAddress interface and components using it to support custom avatar
  • Fix ENS name truncation on Wallet component
  • Fix Wallet component to only resolve user ENS name when name property is not set
  • Update Wallet component to support custom chainId and wagmi configurations

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team August 5, 2024 07:30
thekidnamedkd
thekidnamedkd previously approved these changes Aug 5, 2024
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just the teeensy tiny edit. 🥇

@cgero-eth cgero-eth force-pushed the fixes-on-wallet-component branch from 35b961d to bb79203 Compare August 5, 2024 08:24
@cgero-eth cgero-eth merged commit 736dd2b into main Aug 5, 2024
4 checks passed
@cgero-eth cgero-eth deleted the fixes-on-wallet-component branch August 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants