Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Apply minor fixes to form core components #276

Merged
merged 16 commits into from
Aug 20, 2024
Merged

fix: Apply minor fixes to form core components #276

merged 16 commits into from
Aug 20, 2024

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Aug 19, 2024

Description

  • Implement useRandomId hook and update fields components to use it
  • Update <TextAreaRichText /> core component to expose immediatelyRender property for SSR usage
  • Update <RadioGroup />, <CheckboxGroup /> and <Switch /> core components to render the InputContainer
    component and support the label, helpText, alert and isOptional properties.
  • Hide ens loader indicator on <Wallet /> module component for mobile devices
  • Fix Storybook stories path of <Checkbox /> core components
  • Move <Radio /> core components under /forms folder
  • Fix <InputFileAvatar /> props interface to only expose supported props
  • Default type attribute of <Button /> core component to button
  • Rename label property on <Switch /> core component to inlineLabel to also support the existing label
    property from the InputContainer component.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth changed the title WIP fix: Apply minor fixes to form core components fix: Apply minor fixes to form core components Aug 20, 2024
@cgero-eth cgero-eth marked this pull request as ready for review August 20, 2024 08:06
@cgero-eth cgero-eth force-pushed the form-fixes branch 2 times, most recently from adfd866 to 1a7b3a2 Compare August 20, 2024 08:31
@cgero-eth cgero-eth merged commit 273e4e5 into main Aug 20, 2024
4 checks passed
@cgero-eth cgero-eth deleted the form-fixes branch August 20, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant