Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truncation to vote proposal item #302

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Sep 26, 2024

Description

Fix truncation issue on <VoteProposalDateListItemStructure /> component

Task: APP-3490

Type of change

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

thekidnamedkd
thekidnamedkd previously approved these changes Sep 26, 2024
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - left one suggestion. ✨

Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shan8851 shan8851 merged commit 6a160d9 into main Sep 26, 2024
4 checks passed
@shan8851 shan8851 deleted the add-truncation-to-vote-proposal-item branch September 26, 2024 08:50
cgero-eth pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants