Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(APP-3845): Update TransactionDataListItem for amountUsd prop #375

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jan 3, 2025

Description

Updates the Transaction DLI to receive amountUsd prop and removes the client side calculation

Task: APP-3845

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the
    latest version.

@thekidnamedkd thekidnamedkd changed the title WIP fix(APP-3845): Update TransactionDataListItem for amountUsd prop fix(APP-3845): Update TransactionDataListItem for amountUsd prop Jan 6, 2025
@thekidnamedkd thekidnamedkd requested a review from a team January 6, 2025 13:59
@cgero-eth cgero-eth merged commit 4089253 into main Jan 7, 2025
4 checks passed
@cgero-eth cgero-eth deleted the fix/APP-3845-kit branch January 7, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants