Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pull-request template #392

Merged
merged 1 commit into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ Task: [APP-0000](https://aragonassociation.atlassian.net/browse/APP-0000)

## Checklist:

- [ ] I have selected the correct base branch.
- [ ] I have performed a self-review of my own code.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have made corresponding changes to the documentation.
- [ ] My changes generate no new warnings.
- [ ] Any dependent changes have been merged and published in downstream modules.
- [ ] I ran all tests with success and extended them if necessary.
- [ ] I have updated the `CHANGELOG.md` file in the root folder of the package after the [UPCOMING] title and before the
latest version.
- [ ] I have tested my code on the test network.
- [ ] Manually smoke tested the functionality locally
- [ ] Confirmed there are no new warnings or errors in the browser console
- [ ] Made the corresponding changes to the documentation
- [ ] Added tests that prove my fix is effective or that my feature works
- [ ] Updated the `CHANGELOG.md` file after the [UPCOMING] title and before the latest version
- [ ] (For User Stories only) Double-checked that all Acceptance Criteria are satisified
- [ ] Confirmed there are no new warnings on automated tests
- [ ] Selected the correct base branch
- [ ] Commented the code in hard-to-understand areas
- [ ] Followed the code style guidelines of this project
- [ ] Reviewed that the files changed in GitHub’s UI reflect my intended changes
- [ ] Confirmed the pipeline checks are not failing
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

- Update minor and patch NPM dependencies
- Bump `framer-motion` from 11.17.1 to 12.0.0
- Update pull-request template

### Fixed

Expand Down
Loading