Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APP-2612 - Implement Tag component #46

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat: APP-2612 - Implement Tag component #46

merged 4 commits into from
Nov 23, 2023

Conversation

cgero-eth
Copy link
Member

@cgero-eth cgero-eth commented Nov 20, 2023 •
edited by jira bot
Loading

Description

  • Implement Tag component

Task: APP-2612

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@cgero-eth cgero-eth requested a review from a team November 20, 2023 15:47
@Fabricevladimir Fabricevladimir requested review from Fabricevladimir and removed request for a team November 22, 2023 14:26
Fabricevladimir
Fabricevladimir approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@Fabricevladimir Fabricevladimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@cgero-eth cgero-eth merged commit f79ba03 into main Nov 23, 2023
3 checks passed
@cgero-eth cgero-eth deleted the feat-tag-component branch November 23, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fabricevladimir Fabricevladimir Fabricevladimir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgero-eth @Fabricevladimir