Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: APP-2817 - Remove brackets from maxlength tip, only show tip if no alert #65

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix: APP-2817 - Remove brackets from maxlength tip, only show tip if no alert #65

merged 4 commits into from
Jan 23, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jan 23, 2024 •
edited
Loading

Description

Task: APP-2817

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.
  • I have tested my code on the test network.

@thekidnamedkd thekidnamedkd requested review from a team and cgero-eth January 23, 2024 12:56
cgero-eth
cgero-eth reviewed Jan 23, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @thekidnamedkd! Only left one small comment.
Please also rename the PR name to add the ticket number:
fix/chore/feat: APP-XXXX - [comment
As this PR changes the style of a component, I think a fix suits better than chore

src/components/input/inputContainer/inputContainer.test.tsx Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd changed the title chore: remove brackets from maxlength tip, only show tip if no alert fix: APP-2817 -- remove brackets from maxlength tip, only show tip if no alert Jan 23, 2024
@cgero-eth cgero-eth changed the title fix: APP-2817 -- remove brackets from maxlength tip, only show tip if no alert fix: APP-2817 - Remove brackets from maxlength tip, only show tip if no alert Jan 23, 2024
cgero-eth
cgero-eth approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@thekidnamedkd thekidnamedkd merged commit bb49d33 into main Jan 23, 2024
5 checks passed
@thekidnamedkd thekidnamedkd deleted the chore/APP-2817 branch January 23, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth