Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-2715 - Implement EmptyState Component #77

Merged
merged 36 commits into from
Feb 7, 2024
Merged

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Jan 31, 2024

Description

This will implement a component for EmptyState. Handles optionality for stacked/non-stacked and the specific design specs therein.

Task: APP-2715

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before
    the latest version.

@thekidnamedkd thekidnamedkd marked this pull request as draft January 31, 2024 18:09
@thekidnamedkd thekidnamedkd changed the title feat/app 2715 DRAFT: feat/app 2715 Jan 31, 2024
@thekidnamedkd thekidnamedkd marked this pull request as ready for review February 1, 2024 09:56
@thekidnamedkd thekidnamedkd requested a review from a team February 1, 2024 09:56
@thekidnamedkd thekidnamedkd changed the title DRAFT: feat/app 2715 feat: APP-2715 - implement EmptyState for Card usage Feb 1, 2024
@thekidnamedkd thekidnamedkd changed the title feat: APP-2715 - implement EmptyState for Card usage feat: APP-2715 - implement EmptyState Feb 2, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation @thekidnamedkd, had an initial review of the PR. I will have another check of the stories/tests after the properties update

src/components/emptyState/emptyState.stories.tsx Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.api.ts Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.api.ts Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.api.ts Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/emptyState/emptyState.test.tsx Outdated Show resolved Hide resolved
@cgero-eth
Copy link
Member

Please uppercase the PR comment => Implement EmptyState component

src/components/states/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/states/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/states/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/states/emptyState/emptyState.tsx Outdated Show resolved Hide resolved
src/components/states/emptyState/emptyState.test.tsx Outdated Show resolved Hide resolved
@thekidnamedkd thekidnamedkd changed the title feat: APP-2715 - implement EmptyState feat: APP-2715 - Implement EmptyState Component Feb 7, 2024
Copy link
Member

@cgero-eth cgero-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thekidnamedkd! There's one small conversation still open => #77 (comment), everything else looks good to me ✅

@thekidnamedkd thekidnamedkd merged commit 7d35e4b into main Feb 7, 2024
5 checks passed
@thekidnamedkd thekidnamedkd deleted the feat/APP-2715 branch February 7, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants